-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write SSE headers before subscribing #23840
Write SSE headers before subscribing #23840
Conversation
@cescoffier is it something we should backport? It looks annoying for people using SSE? |
@gsmet Yes, but let's wait for the CI to complete first :-D |
…he Publisher (so before subscription). Fix quarkusio#22762
f0d8337
to
23ab5a0
Compare
My first fix not totally correct. I'm more confident with this one. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building f0d8337
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment
! Skipped: extensions/apicurio-registry-avro/deployment extensions/avro/deployment extensions/grpc/deployment and 87 more 📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive-jackson/deployment extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb/deployment extensions/resteasy-reactive/quarkus-resteasy-reactive-jsonb/deployment
! Skipped: extensions/hibernate-reactive/deployment extensions/oidc-client-reactive-filter/deployment extensions/oidc-token-propagation-reactive/deployment and 34 more 📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-jackson/deployment✖
✖
✖
✖
📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb/deployment✖
✖
📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-jsonb/deployment✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment
! Skipped: extensions/apicurio-registry-avro/deployment extensions/avro/deployment extensions/grpc/deployment and 87 more 📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment✖
|
When using SSE send the headers (and flush them) as soon as we have the Publisher (so before subscription).
Fix #22762