Fix apicurio regression #23740
Closed
Fix apicurio regression #23740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with Apicurio dev services brought about by a recent refactor. Also aligns the dev service version with the java version.
quarkus-bot
bot
added
the
area/dependencies
famod
reviewed
Feb 15, 2022
| @@ -29,7 +29,7 @@ | |||
| * The Apicurio Registry image to use. | |||
| * Note that only Apicurio Registry 2.x images are supported. | |||
| */ | |||
| @ConfigItem(defaultValue = "docker.io/apicurio/apicurio-registry-mem:2.1.5.Final") | |||
| @ConfigItem(defaultValue = "docker.io/apicurio/apicurio-registry-mem:2.2.0.Final") | |||
There was a problem hiding this comment.
Hum, I suppose this has to be defined in this "static" way? Asking because of #23428.
There was a problem hiding this comment.
We can definitely improve this, although it is outside the scope of this PR.
|
Does this mean that whatever Quarkus version contains this will require an Apicurio 2.2.0.Final instance? Will an app continue to work against an Apicurio 2.1.5.Final instance? |
|
It should still work against 2.1.5.Final, I just noticed that the devservice version was not aligned. The real issue is that the REST url base path was not being appended to the property. |
geoand
approved these changes
Feb 16, 2022
|
This now actually has a conflict because of #23733 going in |
|
Looks like this is not needed any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with Apicurio dev services brought about by a recent
refactor. Also aligns the dev service version with the java version.