-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various Files.list resource leaks #23464
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 97f8cd4
Failures⚙️ Initial JDK 11 Build #- Failing: independent-projects/tools/registry-client
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 627 more 📦 independent-projects/tools/registry-client✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 86a81b5
Failures⚙️ Initial JDK 11 Build #- Failing: independent-projects/tools/registry-client
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 627 more 📦 independent-projects/tools/registry-client✖ |
Looks good, except the formatting issue. |
The stream returned by Files.list must be closed according to the Javadoc. In most usages it was correctly done, but there were a few that had slipped through
Formatting fixed |
Failing Jobs - Building c9d6848
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/resteasy-classic/resteasy/deployment
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 284 more 📦 extensions/resteasy-classic/resteasy/deployment✖
|
That |
The stream returned by Files.list must be closed according
to the Javadoc.
In most usages it was correctly done, but there were a few that had
slipped through