Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various Files.list resource leaks #23464

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 6, 2022

The stream returned by Files.list must be closed according
to the Javadoc.
In most usages it was correctly done, but there were a few that had
slipped through

@geoand geoand requested a review from aloubyansky February 6, 2022 17:37
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/smallrye labels Feb 6, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 6, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 97f8cd4

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/tools/registry-client 
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 627 more

📦 independent-projects/tools/registry-client

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-devtools-registry-client: File '/home/runner/work/quarkus/quarkus/independent-projects/tools/registry-client/src/main/java/io/quarkus/registry/client/maven/MavenRegistryCache.java' has not been previously formatted. Please format file and commit before running validation!

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 6, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 86a81b5

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/tools/registry-client 
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 627 more

📦 independent-projects/tools/registry-client

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-devtools-registry-client: File '/home/runner/work/quarkus/quarkus/independent-projects/tools/registry-client/src/main/java/io/quarkus/registry/client/maven/MavenRegistryCache.java' has not been previously formatted. Please format file and commit before running validation!

@aloubyansky
Copy link
Member

Looks good, except the formatting issue.

The stream returned by Files.list must be closed according
to the Javadoc.
In most usages it was correctly done, but there were a few that had
slipped through
@geoand
Copy link
Contributor Author

geoand commented Feb 6, 2022

Formatting fixed

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 6, 2022

Failing Jobs - Building c9d6848

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/resteasy/deployment 
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 284 more

📦 extensions/resteasy-classic/resteasy/deployment

io.quarkus.resteasy.test.IncompletePostTestCase.testIncompleteWrite line 36 - More details - Source on GitHub

java.net.ConnectException: Connection refused: connect
	at java.base/java.net.PlainSocketImpl.connect0(Native Method)
	at java.base/java.net.PlainSocketImpl.socketConnect(PlainSocketImpl.java:101)

@famod
Copy link
Member

famod commented Feb 6, 2022

That IncompletePostTestCase is failing a lot lately -> flaky.

@famod famod merged commit 07a86fe into quarkusio:main Feb 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 6, 2022
@geoand geoand deleted the list-leak branch February 7, 2022 06:18
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.1.Final Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants