Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Hibernate ORM 5.6.5.Final #23187

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Upgrade to Hibernate ORM 5.6.5.Final #23187

merged 1 commit into from
Jan 25, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Jan 25, 2022

No description provided.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jan 25, 2022
@gsmet
Copy link
Member

gsmet commented Jan 25, 2022

In the end, do we upgrade H2?

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 25, 2022
@Sanne
Copy link
Member Author

Sanne commented Jan 25, 2022

In the end, do we upgrade H2?

after a call with Guillaume, we decided to not upgrade H2 yet. It presents an upgrade challenge, and we would need more feedback.

@gsmet FWIW, version 2.1.210 of H2 passed the Hibernate ORM testsuite so it's not too bad. Still, there are several tests disabled, some of which would need to be investigated further.

The purpose of this PR is to provide a little flexibility to end users - they should have better luck experimenting with H2 2.1.210 cc/ @famod (compared with previous versions of Hibernate ORM)

@famod
Copy link
Member

famod commented Jan 25, 2022

All I see is green, so let's merge!

@famod famod merged commit ab5df3c into quarkusio:main Jan 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 25, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 25, 2022
@famod
Copy link
Member

famod commented Jan 25, 2022

@Sanne thanks again for the pointer. Will try out newer h2 once I've updated to Quarkus 2.7.0, but first I have to make sense of those IDENTITY errors I'm getting when running our Liquibase changelogs...

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 25, 2022
@Sanne Sanne deleted the Orm5.6.5.Final branch January 26, 2022 09:18
@famod famod mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

@gsmet gsmet

Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@Sanne @gsmet @famod