Use "full" OpenJDK image #23176
Use "full" OpenJDK image #23176
Conversation
quarkus-bot
bot
added
area/devtools
|
Marking this ready for review to trigger CI. |
There was a problem hiding this comment.
We are waiting for @maxandersen 's green light on this one.
| @@ -20,16 +20,71 @@ | |||
| # | |||
| # docker run -i --rm -p 8080:8080 quarkus/{project.artifact-id}-{type} | |||
| # | |||
| # This image uses the `run-java.sh` script to run the application. | |||
There was a problem hiding this comment.
These docs are fine by now but really should consider putting this in a guide somewhere and link to it instead.
| {#if java.version == '11'} | ||
| ENV AB_JOLOKIA_OFF="" | ||
| {/if} | ||
| ENV JAVA_OPTS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager" |
There was a problem hiding this comment.
JAVA_OPTIONS is standard Java vm env var.
What is the semantics of JAVA_OPTS here?
There was a problem hiding this comment.
lgtm - I can't find fault in these changes; but I found issues in openshift and container image deploy that made it hard/impossible to 100% verify - but afaics this specific change is in a good enough state to merge. if issues it would also be present with the current one in main.
|
I'm curious to know the reasoning about using the full OpenJDK image instead of the runtime... is the runtime image not compatible/supported with Quarkus? On a side note, the Migration-Guide-2.7 should also be updated. |
|
It is. It's just that the runtime image was planned to have run-java by now to simplify /unify how debug and memory settings were handled. That unfortunately didn't make it in yet so instead of breaking "apis" for a period we moved to the full image. Intention is 100% to move to smaller image by default when we can. You can in your own customization of container build choose to just use the runtime image or some other image that has a java runtime. |
and switch back to run-java to start the JVM application