Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade assertj to 3.21.0 to avoid breaking platform members #23087

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Downgrade assertj to 3.21.0 to avoid breaking platform members #23087

merged 1 commit into from
Jan 21, 2022

Conversation

aloubyansky
Copy link
Member

This should be mostly relevant for 2.7. In 2.8 we should look into removing assertj from the quarkus-bom.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jan 21, 2022
@aloubyansky aloubyansky requested a review from gsmet January 21, 2022 11:49
@aloubyansky
Copy link
Member Author

https://github.com/kiegroup/kogito-runtimes/pull/1919#issuecomment-1018433296

@gsmet
Copy link
Member

gsmet commented Jan 21, 2022

But aren't they updating to 3.22?

@aloubyansky
Copy link
Member Author

No, they can't do it currently, AFAIU.

@gsmet
Copy link
Member

gsmet commented Jan 21, 2022

OK, noted, but that's Kogito. Are we sure we won't break others by downgrading? :)

I suppose we can try and see.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 21, 2022
gsmet
gsmet approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent an email to the platform coordination list.

@gsmet gsmet mentioned this pull request Jan 21, 2022
Merged
@evacchi
Copy link
Contributor

evacchi commented Jan 21, 2022

thanks folks. We can upgrade when we upgrade to 2.7, but unfortunately we can't right now because of this issue #23076

@gsmet
Copy link
Member

gsmet commented Jan 21, 2022

@evacchi let's stay on 3.21.0 for 2.7 too.

@evacchi
Copy link
Contributor

evacchi commented Jan 21, 2022

fyi @radtriste

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 21, 2022

Failing Jobs - Building 66568fb

Status Name Step Failures Logs Raw logs
✖ MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance

📦 tcks/microprofile-fault-tolerance

✖ org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@gsmet gsmet merged commit 13323a7 into quarkusio:main Jan 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 21, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@aloubyansky @gsmet @evacchi