Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recommended Maven version #23062

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix recommended Maven version #23062

merged 1 commit into from
Jan 20, 2022

Conversation

gastaldi
Copy link
Contributor

Quarkus 2.2 requires Maven 3.8.1+.
Fixes #22472

@gsmet @gastaldi
Fix recommended Maven version for 2.2
aaf8dea 
Quarkus 2.2 requires Maven 3.8.1+.
Fixes quarkusio#22472
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jan 20, 2022
@gastaldi gastaldi mentioned this pull request Jan 20, 2022
Merged
@gastaldi gastaldi requested review from aloubyansky and gsmet January 20, 2022 15:06
@gsmet gsmet changed the title Fix recommended Maven version for 2.2 Fix recommended Maven version Jan 20, 2022
@gsmet
Copy link
Member

gsmet commented Jan 20, 2022

Ah so that explains @jorsol 's comment :). Thanks!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

Failing Jobs - Building aaf8dea

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Build Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

@gastaldi gastaldi merged commit 2040416 into quarkusio:main Jan 20, 2022
@gastaldi gastaldi deleted the maven branch January 20, 2022 21:28
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 20, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 20, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging this pull request may close these issues.

Set correct supported maven version
3 participants
@gastaldi @gsmet @aloubyansky