Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC providers fixes #23061

Merged
merged 2 commits into from
Jan 21, 2022
Merged

OIDC providers fixes #23061

merged 2 commits into from
Jan 21, 2022

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Jan 20, 2022

Updates the facebook provider now that it supports an id token. Also for free, a missing exception cause.

@FroMage FroMage requested a review from sberyozkin January 20, 2022 13:36
@sberyozkin
Copy link
Member

sberyozkin commented Jan 20, 2022

Thanks @FroMage, you probably need to remove this check and this check :-).
I see I missed testing the apple properties which are removed in this PR, so it should be fine with apple

@sberyozkin
Copy link
Member

sberyozkin commented Jan 20, 2022

@FroMage By the way, let me remove Fixes 23007 - I'll work on making sure setting idTokenRequired=false does not cause a failure if IdToken is actually returned

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 28ced64

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/oidc/runtime 
! Skipped: extensions/keycloak-authorization/deployment extensions/keycloak-authorization/runtime extensions/oidc-client-filter/deployment and 16 more

📦 extensions/oidc/runtime

io.quarkus.oidc.runtime.OidcUtilsTest.testAcceptFacebookProperties line 98 - More details - Source on GitHub

java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.get(Optional.java:148)
	at io.quarkus.oidc.runtime.OidcUtilsTest.testAcceptFacebookProperties(OidcUtilsTest.java:98)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/oidc/runtime 
! Skipped: extensions/keycloak-authorization/deployment extensions/keycloak-authorization/runtime extensions/oidc-client-filter/deployment and 16 more

📦 extensions/oidc/runtime

io.quarkus.oidc.runtime.OidcUtilsTest.testAcceptFacebookProperties line 98 - More details - Source on GitHub

java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.get(Optional.java:148)
	at io.quarkus.oidc.runtime.OidcUtilsTest.testAcceptFacebookProperties(OidcUtilsTest.java:98)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc/runtime 
! Skipped: extensions/keycloak-authorization/deployment extensions/keycloak-authorization/runtime extensions/oidc-client-filter/deployment and 16 more

📦 extensions/oidc/runtime

io.quarkus.oidc.runtime.OidcUtilsTest.testAcceptFacebookProperties line 98 - More details - Source on GitHub

java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.get(Optional.java:143)
	at io.quarkus.oidc.runtime.OidcUtilsTest.testAcceptFacebookProperties(OidcUtilsTest.java:98)

@gsmet
Copy link
Member

gsmet commented Jan 21, 2022

CI is unhappy. See @sberyozkin comment above.

Please let's try to get this merged by Tuesday evening to get this into 2.7.

Also clean up Apple properties that we don't actually support ATM
@FroMage FroMage force-pushed the oidc-providers-fixes branch from 28ced64 to dedfad2 Compare January 21, 2022 16:44
@FroMage
Copy link
Member Author

FroMage commented Jan 21, 2022

Updated with suggestions including from #22572 (comment)

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@sberyozkin sberyozkin merged commit 7a1e69e into quarkusio:main Jan 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 21, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants