-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC providers fixes #23061
OIDC providers fixes #23061
Conversation
@FroMage By the way, let me remove |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 28ced64
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/oidc/runtime
! Skipped: extensions/keycloak-authorization/deployment extensions/keycloak-authorization/runtime extensions/oidc-client-filter/deployment and 16 more 📦 extensions/oidc/runtime✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/oidc/runtime
! Skipped: extensions/keycloak-authorization/deployment extensions/keycloak-authorization/runtime extensions/oidc-client-filter/deployment and 16 more 📦 extensions/oidc/runtime✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/oidc/runtime
! Skipped: extensions/keycloak-authorization/deployment extensions/keycloak-authorization/runtime extensions/oidc-client-filter/deployment and 16 more 📦 extensions/oidc/runtime✖
|
CI is unhappy. See @sberyozkin comment above. Please let's try to get this merged by Tuesday evening to get this into 2.7. |
Also clean up Apple properties that we don't actually support ATM
28ced64
to
dedfad2
Compare
Updated with suggestions including from #22572 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Updates the facebook provider now that it supports an id token. Also for free, a missing exception cause.