Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potential NPE when collecting RESTEasy Providers on Resource classes #23019

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 19, 2022

Addresses: #14418 (comment)

@geoand geoand requested a review from gsmet January 19, 2022 16:25
@quarkus-bot

This comment has been minimized.

@geoand geoand changed the title Avoid potential NPE when collecting RESTEasy Providers on Resource cl… Avoid potential NPE when collecting RESTEasy Providers on Resource classes Jan 19, 2022
@gsmet gsmet added this to the 2.6.3.Final milestone Jan 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 19, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e104aa1

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.JandexMultiModuleProjectDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-classic/rest-client/deployment 
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-authorization/deployment extensions/liquibase-mongodb/deployment and 71 more

📦 extensions/resteasy-classic/rest-client/deployment

io.quarkus.restclient.configuration.UnknownConfigTest. line 29 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Expected 0 warnings ==> expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@gsmet
Copy link
Member

gsmet commented Jan 19, 2022

Really, it wasn't necessary to ask another CI run.

@geoand
Copy link
Contributor Author

geoand commented Jan 19, 2022

Yeah, I just wanted to be sure. But we likely have a flaky test

@gsmet
Copy link
Member

gsmet commented Jan 19, 2022

Yeah the io.quarkus.restclient.configuration.UnknownConfigTest has been flaky for a while. I pinged @radcortez and @michalszynkiewicz about it already.
And the Gradle stuff has also been a pain lately.

@radcortez
Copy link
Member

Yeah the io.quarkus.restclient.configuration.UnknownConfigTest has been flaky for a while. I pinged @radcortez and @michalszynkiewicz about it already.

Sorry, forgot about it. #23037 should do the trick.

@geoand geoand merged commit d666b48 into quarkusio:main Jan 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

Milestone is already set for some of the items:

  • The pull request itself

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@geoand geoand deleted the #14418-rc branch January 20, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants