Fix response truncation #22996

stuartwdouglas · 2022-01-19T05:37:02Z

If the response is an exact multiple of the buffer size it is being
truncated.

The existing code based on calculating the number of buffers has other issues as well, including:

not handling already buffered data
The remainder can be written out of order, as it is written to the buffer immediately

If the response is an exact multiple of the buffer size it is being truncated. Fixes quarkusio#22973

quarkus-bot · 2022-01-19T08:54:41Z

Failing Jobs - Building `6a7a0f7`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

- Failing: extensions/security-jpa/deployment

✖ io.quarkus.security.jpa.NaturalIdConfigurationTest.testJaxrsPathUserRoleSuccess - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <401>.

famod · 2022-01-19T09:36:29Z

That one test failure isn't related (passes on my local machine).

Fix response truncation

6a7a0f7

If the response is an exact multiple of the buffer size it is being truncated. Fixes quarkusio#22973

stuartwdouglas requested a review from geoand January 19, 2022 05:37

geoand approved these changes Jan 19, 2022

View reviewed changes

geoand added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 19, 2022

geoand added the triage/backport? label Jan 19, 2022

famod merged commit 5d653f8 into quarkusio:main Jan 19, 2022

quarkus-bot bot added this to the 2.8 - main milestone Jan 19, 2022

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 19, 2022

gsmet modified the milestones: 2.8 - main, 2.6.3.Final Jan 19, 2022

gsmet removed triage/backport-2.6? labels Jan 19, 2022