Use -Prelocations in update-extension-dependencies.sh & filter out quarkus-amazon-common
#22993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t `quarkus-amazon-common`
gsmet
reviewed
Jan 18, 2022
famod
commented
Jan 18, 2022
| mvn -q -e -Dquickly -Dno-test-modules -Prelocations -T0.8C -f "${PRG_PATH}" $* | ||
| else | ||
| echo '' | ||
| echo 'Aborted!' |
There was a problem hiding this comment.
Btw, the idea behind kinda forcing the build is that I don't expect anyone to have built with -Prelocations before calling this script.
gsmet
approved these changes
Jan 18, 2022
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building ce38f05
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-classic/rest-client/deployment
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-authorization/deployment extensions/liquibase-mongodb/deployment and 71 more📦 extensions/resteasy-classic/rest-client/deployment✖ |
Merged
|
This is mergable once the inititial jdk11 build was ok. |
|
PS: I deliberately merged before the JDK jobs finished as those won't be affected by this change aynway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22836, but filtering of
quarkus-amazon-commonis only a mitigation forquarkus-amazon-commonstill ending up inquarkus-bom-quarkus-platform-descriptor-*.jsonbecause the generation does not respect the build tree/workspace.Will create another issue after this is merged.