Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty @BeanParam class with non-empty super class #22972

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Allow empty @BeanParam class with non-empty super class #22972

merged 1 commit into from
Jan 19, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 18, 2022

Fixes: #22941

@geoand geoand requested a review from FroMage January 18, 2022 14:28
@gsmet gsmet modified the milestone: 2.7 - main Jan 18, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 18, 2022

Failing Jobs - Building 3af2384

Status Name Step Failures Logs Raw logs
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand
Copy link
Contributor Author

geoand commented Jan 19, 2022

Gradle failure is totally unrelated

FroMage
FroMage approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit effb7b4 into quarkusio:main Jan 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 19, 2022
@geoand geoand deleted the #22941 branch January 19, 2022 10:48
@gsmet gsmet modified the milestones: 2.8 - main, 2.6.3.Final Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.3.Final
3 participants
@geoand @FroMage @gsmet