Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for programmatic REST Client Reactive registration #22939

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Fix documentation for programmatic REST Client Reactive registration #22939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/src/main/asciidoc/rest-client-reactive.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ import org.eclipse.microprofile.rest.client.inject.RestClient;

import javax.ws.rs.GET;
import javax.ws.rs.Path;
import java.net.URI;
import java.util.Set;
import java.util.concurrent.CompletionStage;

Expand All @@ -286,7 +287,7 @@ public class ExtensionsResource {

public ExtensionsResource() {
extensionsService = RestClientBuilder.newBuilder()
.baseUri("https://stage.code.quarkus.io/api")
.baseUri(URI.create("https://stage.code.quarkus.io/api"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add a way to use a string instead. But maybe it's a bad idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like a good idea to me, but the user would have to downcast to get it

.build(ExtensionsService.class);
}

Expand Down