Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup to some tests that register custom config #22921

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Minor cleanup to some tests that register custom config #22921

merged 1 commit into from
Jan 17, 2022

Conversation

famod
Copy link
Member

@famod famod commented Jan 15, 2022

As discussed here: #22821 (comment)

Btw, that superfluous catch also exists in some main classes (e.g. ExtensionLoader), but I didn't want to touch those.

@famod famod requested a review from radcortez January 17, 2022 21:37
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 17, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c127043

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: core/runtime 
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 674 more

📦 core/runtime

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-core: Imports are not sorted in /home/runner/work/quarkus/quarkus/core/runtime/src/test/java/io/quarkus/runtime/configuration/DotEnvTestCase.java

@famod famod merged commit 60bc5e6 into quarkusio:main Jan 17, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 17, 2022
@famod famod deleted the config-tests branch January 17, 2022 23:23
@radcortez
Copy link
Member

Thanks for the PR @famod :)

@famod
Copy link
Member Author

famod commented Jan 17, 2022

Yw, thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants