Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute - support global variables #22861

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Qute - support global variables #22861

merged 1 commit into from
Jan 13, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 13, 2022

@mkouba mkouba requested review from FroMage and gastaldi and removed request for FroMage January 13, 2022 11:14
@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Jan 13, 2022
@mkouba mkouba added this to the 2.7 - main milestone Jan 13, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d9ba62b

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/qute/core 
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 620 more

📦 independent-projects/qute/core

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project qute-core: Imports are not sorted in /home/runner/work/quarkus/quarkus/independent-projects/qute/core/src/main/java/io/quarkus/qute/TemplateInstance.java

- supplied by static fields/methods annotated with
io.quarkus.qute.TemplateGlobal
- resolves quarkusio#21853
@mkouba
Copy link
Contributor Author

mkouba commented Jan 13, 2022

@FroMage I assume you're too busy to review this ;-). Anyway, I'm going to merge this PR and feel free to create a follow-up issue if you run into any problem while using global variables together with Renarde...

@mkouba mkouba merged commit 9c9bff9 into quarkusio:main Jan 13, 2022
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it, works like a charm, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute: support globals
3 participants