Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OidcClientConfig Grant getter and setter #22860

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

sberyozkin
Copy link
Member

Minor OidcClientConfig update related to this https://stackoverflow.com/questions/70594412/quarkus-oidc-client-grant-configuration question

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2022
@gsmet gsmet merged commit e14d6b1 into quarkusio:main Jan 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 13, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2022
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.3.Final Jan 15, 2022
@r00ta
Copy link
Contributor

r00ta commented Jan 17, 2022

Hi @sberyozkin , thank you very much for the PR!
One last thing I faced is that the mapping between the config string and the enum has to be done somehow on client side. I implemented this https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/blob/main/infra/src/main/java/com/redhat/service/bridge/infra/auth/OidcClientConfigUtils.java but it might be useful if it's the library to expose it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants