Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take response status of aborted request into account in JAX-RS Client #22859

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 13, 2022

Fixes: #22827

@geoand geoand merged commit eae43d8 into quarkusio:main Jan 14, 2022
@geoand geoand deleted the #22827 branch January 14, 2022 10:33
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 14, 2022
@fwippe
Copy link
Contributor

fwippe commented Jan 14, 2022

@geoand Thank you very much for this fix! Alas, as far as I can tell, there are two kinds of reponse information this fix does not include: the status reason phrase and the entity, both of which could contain helpful information. What do you think about setting the entity via setExistingEntity on status 0 detection? Also, the reasonPhrase in the WebClientApplicationException constructor should be extracted from the aborted Response in those cases: requestContext.getAbortedWith().getStatusInfo().getReasonPhrase(). Of course, this implies further refactorings, unfortunately.

@geoand
Copy link
Contributor Author

geoand commented Jan 14, 2022

You can certainly open a draft PR with the proposed suggestion

@fwippe
Copy link
Contributor

fwippe commented Jan 14, 2022

I will give it a try, it could take some time, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC-Client: Response status 0 and null entity when OIDC client auth is failing for Rest-Client-Reactive
4 participants