Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipart download in REST Client Reactive #22855

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Multipart download in REST Client Reactive #22855

merged 1 commit into from
Jan 13, 2022

Conversation

michalszynkiewicz
Copy link
Member

refs #21440

@michalszynkiewicz
Copy link
Member Author

CC @cescoffier @Sgitario

Sgitario
Sgitario reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Two minor comments only.

docs/src/main/asciidoc/rest-client-reactive.adoc Outdated Show resolved Hide resolved
...eployment/src/test/java/io/quarkus/rest/client/reactive/multipart/MultipartResponseTest.java Show resolved Hide resolved
@geoand
Copy link
Contributor

geoand commented Jan 13, 2022

IIUC, this now closes #21440, correct?

If so, please mark it as so in the description

@michalszynkiewicz
Copy link
Member Author

IIUC, this now closes #21440, correct?

If so, please mark it as so in the description

unfortunately not, #21440 is about letting users read files as Mult<Byte> in the responses.
This one is close but not there yet. What we need more is reading File as Multi and deleting files when the multi is read, or request scope is deactivated, or sth.

Sgitario
Sgitario approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@geoand geoand merged commit 9f11cb7 into quarkusio:main Jan 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 13, 2022
@michalszynkiewicz michalszynkiewicz mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamadaliev mamadaliev mamadaliev approved these changes

@Sgitario Sgitario Sgitario approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation area/rest
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@michalszynkiewicz @geoand @Sgitario @mamadaliev