Restore and deprecate GlobUtil in core-deployment #22791
Conversation
| import java.util.regex.Pattern; | ||
|
|
||
| /** | ||
| * @deprecated in favor of {@link io.quarkus.util.GlobUtil} |
There was a problem hiding this comment.
Not related to this PR but I think it's a bad idea to use io.quarkus.util in the bootstrap project. Chances of having a split package later are very high.
There was a problem hiding this comment.
Do you want me to move it to io.quarkus.bootstrap.util or something?
There was a problem hiding this comment.
I don't know what the exact package should be. I had a look at the various bootstrap artifacts and they are very prone to end up with split packages as they all share the same namespace.
You would already have one but you have util in one and utils in the other :).
I'm not exactly sure if this can be fixed so late. Maybe we should talk about it on Zulip tomorrow?
There was a problem hiding this comment.
Yes, we may want to split the bootstrap-core in more modules in perspective. E.g. there is an overlap with dev tools.
There was a problem hiding this comment.
I don't think it's about splitting things in more modules. My concern is that we should have a properly separated root package for each of the existing modules.
The class was moved to the bootstrap project as
io.quarkus.util.GlobUtilin #22673.quarkus-jberetin the quarkiverse org has a dependency on it though.