Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create file when adding a registry to default config #22744

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Create file when adding a registry to default config #22744

merged 1 commit into from
Jan 8, 2022

Conversation

ebullient
Copy link
Member

@ebullient ebullient commented Jan 7, 2022 •
edited
Loading

Rely more on persist capability built into the registry client.
If this is a default config being persisted, use the default config path.
Fixes #22731

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 7, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 7, 2022
@ebullient ebullient changed the title Create file when adding a registry to default config. Fixes #22731 Create file when adding a registry to default config. Jan 7, 2022
@gsmet gsmet changed the title Create file when adding a registry to default config. Create file when adding a registry to default config Jan 7, 2022
@ebullient ebullient mentioned this pull request Jan 7, 2022
Closed
@ebullient ebullient merged commit 4df4ef0 into quarkusio:main Jan 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 8, 2022
@ebullient ebullient deleted the persist-default branch January 8, 2022 03:07
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.2.Final Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glefloch glefloch glefloch approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.6.2.Final
Development

Successfully merging this pull request may close these issues.

NPE when adding new registry in Quarkus CLI
4 participants
@ebullient @aloubyansky @glefloch @gsmet