Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preserve next fire time of rescheduled job in quartz #22717

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix preserve next fire time of rescheduled job in quartz #22717

merged 1 commit into from
Jan 10, 2022

Conversation

ashwinair
Copy link
Contributor

Fixes #21455

@ashwinair ashwinair mentioned this pull request Jan 7, 2022
Closed
@gsmet gsmet requested review from machi1990 and mkouba January 7, 2022 11:44
@geoand
Copy link
Contributor

geoand commented Jan 7, 2022

Thanks for this!

I'll let @machi1990 and @mkouba comment on the change, but we will certainly need the commits merged.

Thanks

@gsmet
Copy link
Member

gsmet commented Jan 7, 2022

I squashed the 2 commits.

@gsmet
Copy link
Member

gsmet commented Jan 7, 2022

@mkouba if you could have a quick look, I think it would be a good candidate for 2.6.2.Final.

@mkouba
Copy link
Contributor

mkouba commented Jan 10, 2022

The solution is probably OK but I'd like @machi1990 to comment on this one as he's our "Quartz clustered jobs" expert ;-)

machi1990
machi1990 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ashwinair for the PR.

@apat59, this should fix the issue your reported in #21455.

@gsmet gsmet merged commit d1bf5f5 into quarkusio:main Jan 10, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 10, 2022
@ashwinair ashwinair deleted the fix/21455 branch January 10, 2022 18:13
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.3.Final Jan 15, 2022
@famod famod mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
area/scheduler
Projects
None yet
Milestone
2.6.3.Final
Development

Successfully merging this pull request may close these issues.

Quarkus quartz should not reschedule jobs on start
5 participants
@ashwinair @geoand @gsmet @mkouba @machi1990