-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply various fixes to Kotlin Serialization modules #22715
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 41295c2
Failures⚙️ Initial JDK 11 Build #- Failing: integration-tests/rest-client-reactive-kotlin-serialization
📦 integration-tests/rest-client-reactive-kotlin-serialization✖ |
This didn't prevent things from working, but it did result in an Arc warning
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 245a307
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/rest-client-reactive-kotlin-serialization
📦 integration-tests/rest-client-reactive-kotlin-serialization✖
✖
|
The fix for #22712 looks good. |
@mkouba mind reviewing please? The other fixes are totally trivial, but very necessary to make the extensions work properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Shall we squash the commits? |
I think it makes sense to keep them given they are all semantic and tell a story. |
My thoughts exactly :) |
Hm, that's a nice idea - you can write a short story in a series of commit comments :D |
Kotlin serialization is in main only so not backporting. |
Fixes: #22712