Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply various fixes to Kotlin Serialization modules #22715

Merged
merged 8 commits into from
Jan 7, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 7, 2022

Fixes: #22712

@geoand geoand changed the title Apply various fixes to Kotlin Apply various fixes to Kotlin Serialization modules Jan 7, 2022
@quarkus-bot quarkus-bot bot added the area/rest label Jan 7, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 7, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 41295c2

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: integration-tests/rest-client-reactive-kotlin-serialization 

📦 integration-tests/rest-client-reactive-kotlin-serialization

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.6.10:compile (compile) on project quarkus-integration-test-rest-client-reactive-kotlin-serialization: Compilation failure

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 7, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 245a307

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/rest-client-reactive-kotlin-serialization 

📦 integration-tests/rest-client-reactive-kotlin-serialization

io.quarkus.it.rest.client.BasicTest.callCountries line 28 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "OK"

io.quarkus.it.rest.client.BasicTest.callCountry line 20 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "Sthlm"

@mkouba
Copy link
Contributor

mkouba commented Jan 7, 2022

The fix for #22712 looks good.

@geoand
Copy link
Contributor Author

geoand commented Jan 7, 2022

@mkouba mind reviewing please? The other fixes are totally trivial, but very necessary to make the extensions work properly

Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mkouba
Copy link
Contributor

mkouba commented Jan 7, 2022

Shall we squash the commits?

@gsmet
Copy link
Member

gsmet commented Jan 7, 2022

I think it makes sense to keep them given they are all semantic and tell a story.

@gsmet gsmet merged commit 1ac6221 into quarkusio:main Jan 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 7, 2022
@geoand
Copy link
Contributor Author

geoand commented Jan 7, 2022

I think it makes sense to keep them given they are all semantic and tell a story.

My thoughts exactly :)

@geoand geoand deleted the #22712 branch January 7, 2022 11:17
@mkouba
Copy link
Contributor

mkouba commented Jan 7, 2022

I think it makes sense to keep them given they are all semantic and tell a story.

Hm, that's a nice idea - you can write a short story in a series of commit comments :D

@gsmet
Copy link
Member

gsmet commented Jan 7, 2022

Kotlin serialization is in main only so not backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants