Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that UTF8 is used as the default encoding in RESTEasy Reactive #22644

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 5, 2022

This was already being done when producing text/plain, but in cases
where application/json was being used and the actual entity was a String,
the encoding was not being specified

Fixes: #21700

@geoand
Copy link
Contributor Author

geoand commented Jan 5, 2022

The failures have nothing to do with this PR. We will need #22646 to fix them

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 5, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2a534e8

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-reactive/deployment extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/panache/hibernate-reactive-panache-common/deployment extensions/panache/hibernate-reactive-panache/deployment and 16 more

📦 extensions/hibernate-reactive/deployment

io.quarkus.hibernate.reactive.dev.HibernateReactiveDevModeTest.testListAllFruits line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings line 66 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 8 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings line 66 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/hibernate-reactive/deployment extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/panache/hibernate-reactive-panache-common/deployment extensions/panache/hibernate-reactive-panache/deployment and 16 more

📦 extensions/hibernate-reactive/deployment

io.quarkus.hibernate.reactive.dev.HibernateReactiveDevModeTest.testListAllFruits line 52 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.stork.StorkDevModeTest.shouldModifyStorkSettings line 66 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

This was already being done when producing text/plain, but in cases
where application/json was being used and the actual entity was a String,
the encoding was not being specified

Fixes: quarkusio#21700
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@gsmet gsmet merged commit 3063535 into quarkusio:main Jan 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 5, 2022
@geoand geoand deleted the #21700 branch January 5, 2022 14:56
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.2.Final Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken encoding in response body if application is running on OpenShift
2 participants