Enforce an RFC valid Accept value for remote dev requests #22621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Accept header defined in sun.net.www.protocol.http.HttpURLConnection is invalid and does not respect the RFC so we override it with a valid value. RESTEasy is quite strict regarding the RFC and throws an error. Note that this is just the default HttpURLConnection header value made valid. See https://bugs.openjdk.java.net/browse/JDK-8163921 and https://bugs.openjdk.java.net/browse/JDK-8177439 Fixes quarkusio#20904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Accept header defined in
sun.net.www.protocol.http.HttpURLConnectionis invalid anddoes not respect the RFC so we override it with a valid value.
RESTEasy is quite strict regarding the RFC and throws an error.
Note that this is just the default HttpURLConnection header value
made valid.
See https://bugs.openjdk.java.net/browse/JDK-8163921
and https://bugs.openjdk.java.net/browse/JDK-8177439
Fixes #20904