Restore the older native docker file using UBI minimal as base image #22617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
|
@maxandersen can you have a look? |
gsmet
approved these changes
Jan 12, 2022
fedinskiy
reviewed
Jan 12, 2022
| @@ -497,6 +497,23 @@ And finally, run it with: | |||
| docker run -i --rm -p 8080:8080 quarkus-quickstart/getting-started | |||
| ---- | |||
|
|
|||
| === Manually using the minimal base image | |||
There was a problem hiding this comment.
According to this file[1] content looks differently. Is this expected?
There was a problem hiding this comment.
Could you be more explicit? I have no idea what you're complaining about :).
There was a problem hiding this comment.
Dockerfile from docs/src/main/asciidoc/building-native-image.adoc (lines 506-512):
FROM <...>
WORKDIR /work/
COPY target/*-runner /work/application
RUN chmod 775 /work
EXPOSE 8080
CMD <...>
Dockerfile from docs/src/main/asciidoc/quarkus-runtime-base-image.adoc (lines 115-125):
FROM <...>
WORKDIR /work/
RUN chown 1001 /work \
&& chmod "g+rwX" /work \
&& chown 1001:root /work
COPY --chown=1001:root target/*-runner /work/application
EXPOSE 8080
USER 1001
CMD <...>
It looks like these commands target the same case, yet they are different. What I am curious about, is if it intentional, or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxandersen as discussed.