Move RESTEasy provider registration as unremovable beans to common module #22609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because without this change, applications that only include the rest-client without including the server component, result in the providers not being registered as unremovable beans. Fixes: quarkusio#22605
This is done in order to ensure that the rest-client properly registers providers when the server part is not around
geoand
commented
Jan 4, 2022
| @@ -3,5 +3,6 @@ quarkus.datasource.jdbc.url=jdbc:tracing:postgresql://localhost:5432/mydatabase | |||
| quarkus.datasource.jdbc.driver=io.opentracing.contrib.jdbc.TracingDriver | |||
| quarkus.datasource.username=sa | |||
| quarkus.datasource.password=sa | |||
| quarkus.rest.single-default-produces=false | |||
There was a problem hiding this comment.
This is needed because RESTEasy Reactive will default to text/plain when returning String from a JAX-RS Resource method, but this default is not what this integration uses
gsmet
approved these changes
Jan 5, 2022
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-resteasy-mutiny</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- Client dependencies --> | ||
| <dependency> |
There was a problem hiding this comment.
I'm thinking about this and I'm not sure it's worth making this test a Frankenstein. I think I would just drop the testing on this one.
But YMMV.
There was a problem hiding this comment.
I actually wanted to have this test because I think it's relatively easy for us to miss this in the future
This was referenced Jan 5, 2022
|
Ah ah, I was looking at fixing #20498 and it ends up being the same issue :). |
|
Excellent ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because without this change, applications that only
include the rest-client without including the server component,
result in the providers not being registered as unremovable beans.
Fixes: #22605
Fixes: #20498