Remove distroless image generation #22583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icro image. Follow up of quarkusio#21557
quarkus-bot
bot
added
area/devtools
geoand
approved these changes
Jan 3, 2022
gsmet
reviewed
Jan 3, 2022
| Quarkus provides the `quay.io/quarkus/quarkus-distroless-image:1.0` image. | ||
| It contains the required packages to run a native executable and is only **9Mb**. | ||
| Just add your application on top of this image, and you will get a tiny container image. | ||
|
|
||
| Distroless images should not be used in production without rigorous testing. |
There was a problem hiding this comment.
Wondering if we should remove this altogether and stop building the image?
There was a problem hiding this comment.
We had requests to have one. It can still be useful even if you get a similar size (15Mb overhead) with the micro image.
gsmet
approved these changes
Jan 3, 2022
|
Unless I'm mistaken, distroless is no option for AWS Lambda? The Quarkus lambda guide is also pulling public.ecr.aws/lambda/provided or public.ecr.aws/lambda/java:11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21557.
Remove the distroless docker file generation in favor of micro.