Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to slf4j 1.7.32 #22570

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Updating to slf4j 1.7.32 #22570

merged 1 commit into from
Jan 2, 2022

Conversation

gunnarmorling
Copy link
Contributor

Fixes #22569

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 1, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jan 1, 2022
@gunnarmorling gunnarmorling changed the title #22569 Updating to slf4j 1.7.32 Updating to slf4j 1.7.32 Jan 1, 2022
@gsmet
Copy link
Member

gsmet commented Jan 1, 2022

Thanks but let's not merge it. I want to figure out why Dependabot didn't update this occurrence and get it fixed.

@gsmet gsmet closed this Jan 1, 2022
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jan 1, 2022
@famod
Copy link
Member

famod commented Jan 1, 2022

@gsmet this looks strange:

@gsmet
Copy link
Member

gsmet commented Jan 1, 2022

This is because of #22571 .

@gsmet gsmet reopened this Jan 1, 2022
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Jan 1, 2022
@gsmet
Copy link
Member

gsmet commented Jan 1, 2022

Hmmm. Looks like this PR #22363 got us in some sort of mess. I have no idea what's going on.

Let's get this in and we will see how it goes for the next upgrade.

@gsmet gsmet merged commit 5e2a021 into quarkusio:main Jan 2, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 2, 2022
@gunnarmorling
Copy link
Contributor Author

Thx for merging, @gsmet! Already was concerned I would miss the opportunity for a Quarkus 3.0 shirt ;)

@gsmet gsmet modified the milestones: 2.7 - main, 2.6.2.Final Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent versions of slf4j-api
3 participants