Remove unsafe cast to mutable extension catalog #22503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
ebullient
approved these changes
Dec 23, 2021
gastaldi
reviewed
Dec 23, 2021
| catalogs.add(memberCatalog); | ||
| ExtensionCatalog.Mutable mutableMemberCatalog = memberCatalog.mutable(); | ||
| mutableMemberCatalog.setMetadata(metadata); | ||
| catalogs.add(mutableMemberCatalog); |
There was a problem hiding this comment.
Suggested change
| catalogs.add(mutableMemberCatalog); | |
| catalogs.add(mutableMemberCatalog.build()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the catalog is mutable by explicitly converting it.
close #22498
close #22496