Properly determine tenant resolver in HibernateMultiTenantConnectionProvider #22502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-orm
gastaldi
approved these changes
Dec 23, 2021
gsmet
commented
Dec 23, 2021
| resolverInstance = Arc.container().instance(TenantResolver.class, Default.Literal.INSTANCE); | ||
| } else { | ||
| resolverInstance = Arc.container().instance(TenantResolver.class, | ||
| new PersistenceUnitLiteral(persistenceUnitName)); |
There was a problem hiding this comment.
This is the old annotation. The legacySingleExtensionInstanceForPersistenceUnit method I now call, despite its name, supports both the new annotation and the old one if the new one is not found.
gastaldi
added
the
triage/waiting-for-ci
gsmet
changed the title
…rovider When migrating to the new annotation, this was forgotten somehow so it's still using the old annotation. Moving to the method supporting both the new annotation and the old one. Fixes quarkusio#21265
gsmet
force-pushed
the
fix-tenant-resolver-resolution
branch
from
3798e03 to
7aab5f9
Compare
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating to the new annotation, this was forgotten somehow so it's
still using the old annotation.
Moving to the method supporting both the new annotation and the old one.
I verified we don't have the warning in the tests. I'll discuss with @yrodiere when he's back if it's worth adding a test.
Fixes #21265