Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config editor filtering #22448

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Fix config editor filtering #22448

merged 2 commits into from
Dec 22, 2021

Conversation

glefloch
Copy link
Member

this branch fix:

  • display all elements after clear button is clicked
  • when updating the filter, this go through all elements instead of only visible element (allowing typo)

mkouba
mkouba approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

phillip-kruger
phillip-kruger approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit 6fe6cb9 into quarkusio:main Dec 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 22, 2021
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.1.Final Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/vertx
Projects
None yet
Milestone
2.6.1.Final
Development

Successfully merging this pull request may close these issues.
5 participants
@glefloch @mkouba @phillip-kruger @gsmet @geoand