Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remove-maven-artifact-transfer constraint from BOM #22438

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 21, 2021

This is a follow up of #21749
as we removed the property from the BOM but not the constraint.

This is a follow up of quarkusio#21749
as we removed the property from the BOM but not the constraint.
@gsmet gsmet requested a review from famod December 21, 2021 13:43
@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Dec 21, 2021
@gsmet gsmet requested a review from aloubyansky December 21, 2021 13:43
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, didn't even know that Maven doesn't complain in such a case. Good find!

@famod famod added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 21, 2021
@gsmet
Copy link
Member Author

gsmet commented Dec 21, 2021

Well, it does complain with a warning in some scenarios as I saw it somewhere but it doesn't break the build.

@famod famod merged commit e9bd941 into quarkusio:main Dec 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 21, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 21, 2021
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.1.Final Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants