Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmallRye Config to 2.8.0 #22423

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Dec 20, 2021
@gsmet
Copy link
Member

gsmet commented Dec 20, 2021

Is it something we want for 2.6.1.Final or we wait for 2.7?

@radcortez
Copy link
Member Author

I believe we can wait until 2.7. If required users can update manually for now. The version is compatible, I've just bumped the minor due to a new public API (which is not used in Quarkus yet).

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 808e91f

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Misc3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/smallrye-config 

📦 integration-tests/smallrye-config

io.quarkus.it.smallrye.config.ConfigLocationsTest.applicationYamlProfile line 65 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsTest.locations line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsTest.applicationPropertiesProfile line 50 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.dotenv line 40 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.properties line 55 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.mpConfigProperties line 25 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/smallrye-config 

📦 integration-tests/smallrye-config

io.quarkus.it.smallrye.config.ConfigLocationsTest.applicationYamlProfile line 65 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsTest.locations line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsTest.applicationPropertiesProfile line 50 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.dotenv line 40 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.properties line 55 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.mpConfigProperties line 25 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/smallrye-config 

📦 integration-tests/smallrye-config

io.quarkus.it.smallrye.config.ConfigLocationsTest.applicationYamlProfile line 65 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsTest.locations line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsTest.applicationPropertiesProfile line 50 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.dotenv line 40 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.properties line 55 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigTest.mpConfigProperties line 25 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

⚙️ Native Tests - Misc3 #

- Failing: integration-tests/smallrye-config 

📦 integration-tests/smallrye-config

io.quarkus.it.smallrye.config.ConfigLocationsIT.applicationYamlProfile - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsIT.locations - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.ConfigLocationsIT.applicationPropertiesProfile - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigIT.dotenv - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigIT.properties - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

io.quarkus.it.smallrye.config.SmallRyeConfigIT.mpConfigProperties - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path value doesn't match.

@radcortez
Copy link
Member Author

Actually, we need some additional code changes, so let's do this only for 2.7.

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e2fdd9e

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 12 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.LegacyConfigurationTest.configurationShouldBeLoaded line 29 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 8 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.LegacyConfigurationTest.configurationShouldBeLoaded line 29 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 8 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.LegacyConfigurationTest.configurationShouldBeLoaded line 29 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

Expecting value to be true but was false

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building fe6d9d0

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Misc4 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-classic/rest-client-config/runtime 
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-admin-client/runtime extensions/keycloak-authorization/deployment and 96 more

📦 extensions/resteasy-classic/rest-client-config/runtime

io.quarkus.restclient.config.RestClientFallbackConfigSourceInterceptorTest.testGetValue line 97 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "prefix/mp-rest/url"

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-classic/rest-client-config/runtime 
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-admin-client/runtime extensions/keycloak-authorization/deployment and 96 more

📦 extensions/resteasy-classic/rest-client-config/runtime

io.quarkus.restclient.config.RestClientFallbackConfigSourceInterceptorTest.testGetValue line 97 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "prefix/mp-rest/url"

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-classic/rest-client-config/runtime 
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-admin-client/runtime extensions/keycloak-authorization/deployment and 96 more

📦 extensions/resteasy-classic/rest-client-config/runtime

io.quarkus.restclient.config.RestClientFallbackConfigSourceInterceptorTest.testGetValue line 97 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "prefix/mp-rest/url"

⚙️ Native Tests - Misc4 #

- Failing: integration-tests/picocli-native 

📦 integration-tests/picocli-native

io.quarkus.it.picocli.PicocliIT.testParentCommand(LaunchResult) - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "testValue"

io.quarkus.it.picocli.PicocliIT.testDefaultValueProvider(LaunchResult) - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "default:default-value"

io.quarkus.it.picocli.PicocliIT.testMethodSubCommand(QuarkusMainLauncher) - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "Hello World!"

io.quarkus.it.picocli.PicocliIT.testDynamicProxy(LaunchResult) - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "2007-12-03T10:15:30"

io.quarkus.it.picocli.PicocliIT.testLogCapturing(QuarkusMainLauncher) - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "Hello World!"

Record config properties with ConfigValue
This will improve the support of the fallback and relocation mechanisms
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/core area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional mapping error with ConfigMapping using Maps with enum keys, Nested Groups and Optional
3 participants