-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SmallRye Config to 2.8.0 #22423
Conversation
Is it something we want for 2.6.1.Final or we wait for 2.7? |
I believe we can wait until 2.7. If required users can update manually for now. The version is compatible, I've just bumped the minor due to a new public API (which is not used in Quarkus yet). |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 808e91f
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config✖
✖
✖
✖
✖
✖
⚙️ Native Tests - Misc3 #- Failing: integration-tests/smallrye-config
📦 integration-tests/smallrye-config✖
✖
✖
✖
✖
✖
|
808e91f
to
9dde355
Compare
9dde355
to
e2fdd9e
Compare
Actually, we need some additional code changes, so let's do this only for 2.7. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e2fdd9e
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 12 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 8 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment extensions/resteasy-reactive/rest-client-reactive-kotlin-serialization/deployment and 8 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
|
e2fdd9e
to
fe6d9d0
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building fe6d9d0
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-classic/rest-client-config/runtime
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-admin-client/runtime extensions/keycloak-authorization/deployment and 96 more 📦 extensions/resteasy-classic/rest-client-config/runtime✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/resteasy-classic/rest-client-config/runtime
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-admin-client/runtime extensions/keycloak-authorization/deployment and 96 more 📦 extensions/resteasy-classic/rest-client-config/runtime✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/resteasy-classic/rest-client-config/runtime
! Skipped: extensions/keycloak-admin-client/deployment extensions/keycloak-admin-client/runtime extensions/keycloak-authorization/deployment and 96 more 📦 extensions/resteasy-classic/rest-client-config/runtime✖
⚙️ Native Tests - Misc4 #- Failing: integration-tests/picocli-native
📦 integration-tests/picocli-native✖
✖
✖
✖
✖
|
Record config properties with ConfigValue This will improve the support of the fallback and relocation mechanisms
fe6d9d0
to
4c2c376
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/smallrye/smallrye-config/releases/tag/2.8.0