Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWT TS: Exceptions worded differently JDK11/17 vs. JDK18/19 #22419

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

Karm
Copy link
Member

@Karm Karm commented Dec 20, 2021

Fixes #22067

An intentionally incorrect image is supposed to trigger an exception
about color profiles / palettes. The exception message states:

JDK 11, 17: "Can not access specified profile."
JDK 18, 19: "LCMS error 13: LUT is not suitable to be saved as LutBToA"

This commit improves the regular expression that checks the message.
It also replaces |' with █' as a separator in test data and utils
so as `|' doesn't break regular expressions parsing.

Fixes quarkusio#22067

An intentionally incorrect image is supposed to trigger an exception
about color profiles / palettes. The exception message states:

JDK 11, 17: "Can not access specified profile."
JDK 18, 19: "LCMS error 13: LUT is not suitable to be saved as LutBToA"

This commit improves the regular expression that checks the message.
It also replaces `|' with `█' as a separator in test data and utils
so as `|' doesn't break regular expressions parsing.
@Karm Karm requested a review from gsmet December 20, 2021 19:48
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 20, 2021

/cc @galderz, @zakkak

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 20, 2021
@gsmet gsmet merged commit 5dc1772 into quarkusio:main Dec 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 20, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 20, 2021
@gsmet
Copy link
Member

gsmet commented Dec 20, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWT tests broken with JDK 18 EA
2 participants