Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor build fixes #22410

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Minor build fixes #22410

merged 2 commits into from
Dec 21, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 20, 2021

@famod as discussed.

@gsmet gsmet requested a review from famod December 20, 2021 16:51
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Dec 20, 2021
<groupId>com.github.javaparser</groupId>
<artifactId>javaparser-core</artifactId>
<version>${javaparser-core.version}</version>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking about doing it the other way around (define both in quarkus-extension-processor), assuming that no other module is going to need either of the two.
Having them in build-parent affects 900 modules (on a version bump) and "only" 655 when in processor.

But I guess this way it's more in line with other existing dependencies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed, but I favored consistency.

@gsmet gsmet merged commit 748e131 into quarkusio:main Dec 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants