Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jquery from 3.5.1 to 3.6.0 and use maven managed versions in webjars tests #22379

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Bump jquery from 3.5.1 to 3.6.0 and use maven managed versions in webjars tests #22379

merged 4 commits into from
Dec 20, 2021

Conversation

famod
Copy link
Member

@famod famod commented Dec 19, 2021

Follows up on #22372.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Dec 19, 2021
@gsmet
Copy link
Member

gsmet commented Dec 19, 2021

So I'm all for this but I would prefer we use https://search.maven.org/artifact/org.webjars/jquery-ui/1.13.0/jar in the locator tests so that we are totally independent from our usage of jQuery for Quarkus itself.

@famod
Copy link
Member Author

famod commented Dec 19, 2021

@gsmet not sure what this setForcedDependencies() bit is about. Would it still cover everything if moving to jquery-ui?

Feel free to take it from here.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gsmet
gsmet previously requested changes Dec 20, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge, I want to adjust things.

dependabot bot and others added 2 commits December 20, 2021 14:07
Bumps [jquery](https://github.com/webjars/jquery) from 3.5.1 to 3.6.0.
- [Release notes](https://github.com/webjars/jquery/releases)
- [Commits](webjars/jquery@jquery-3.5.1...jquery-3.6.0)

---
updated-dependencies:
- dependency-name: org.webjars:jquery
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Dec 20, 2021
@gsmet gsmet dismissed their stale review December 20, 2021 13:07

Addressed

@gsmet
Copy link
Member

gsmet commented Dec 20, 2021

@gastaldi @famod can you have a look at what I did?

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@famod
Copy link
Member Author

famod commented Dec 20, 2021

Haha. just tried to approve my own PR. 🤦‍♂️ LGTM!

@famod famod added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 20, 2021
@gsmet gsmet merged commit b9e861d into quarkusio:main Dec 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 20, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 20, 2021
@famod famod deleted the jquery-3.6.0 branch December 20, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants