-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jquery from 3.5.1 to 3.6.0 and use maven managed versions in webjars tests #22379
Conversation
So I'm all for this but I would prefer we use https://search.maven.org/artifact/org.webjars/jquery-ui/1.13.0/jar in the locator tests so that we are totally independent from our usage of jQuery for Quarkus itself. |
@gsmet not sure what this Feel free to take it from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't merge, I want to adjust things.
Bumps [jquery](https://github.com/webjars/jquery) from 3.5.1 to 3.6.0. - [Release notes](https://github.com/webjars/jquery/releases) - [Commits](webjars/jquery@jquery-3.5.1...jquery-3.6.0) --- updated-dependencies: - dependency-name: org.webjars:jquery dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Haha. just tried to approve my own PR. 🤦♂️ LGTM! |
Follows up on #22372.