Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit the use of legacy Kotlin interface default methods on Reactive REST Client #22276

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Prohibit the use of legacy Kotlin interface default methods on Reactive REST Client #22276

merged 1 commit into from
Jan 4, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 16, 2021 •
edited
Loading

Follow up of: #22241

@geoand geoand mentioned this pull request Dec 16, 2021
Merged
@kdubb
Copy link
Contributor

kdubb commented Dec 16, 2021

@geoand Wouldn't this just trigger the error anytime you had Kotlin default methods? Or does -Xjvm-default=all actually remove these methods from the compiled class file?

@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2021 •
edited
Loading

Or does -Xjvm-default=all actually remove these methods from the compiled class file?

It results in no extra class (i.e. the $DefaultImpls class) being generated

@michalszynkiewicz michalszynkiewicz merged commit 593a2a1 into quarkusio:main Jan 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 4, 2022
@geoand geoand deleted the #22231-followup branch January 4, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalszynkiewicz michalszynkiewicz michalszynkiewicz approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @kdubb @michalszynkiewicz