Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade recommended postgres image to version 14.1 #22159

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Dec 13, 2021

Also removed --ulimit memlock=-1:-1 --memory-swappiness=0 from the recommended parameters in starting scripts: that's making bootstrap slightly faster on linux, but the difference is negligible and not worth the hassle as I've learned Mac users can't use these.

@sberyozkin
Copy link
Member

Thanks @Sanne @gsmet

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2021

Failing Jobs - Building d9373ca

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/kubernetes/maven-invoker-way 

📦 integration-tests/kubernetes/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-kubernetes-invoker: 1 build failed. See console output above for details.


⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/kubernetes/maven-invoker-way 

📦 integration-tests/kubernetes/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-kubernetes-invoker: 1 build failed. See console output above for details.

@gastaldi
Copy link
Contributor

Failure is unrelated. Merging this

@gastaldi gastaldi merged commit 8242e38 into quarkusio:main Dec 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 13, 2021
@gastaldi
Copy link
Contributor

It would be nice to backport this, WDYT @gsmet ?

@gsmet
Copy link
Member

gsmet commented Dec 13, 2021

Please check the failures more carefully. They are related:

assert service.metadata.labels.get("app.kubernetes.io/version") == "10.6"
3920
       |       |        |      |                                |
3921
       |       |        |      '14.1'                           false
3922
       |       |        ['app.kubernetes.io/name':'postgres', 'app.kubernetes.io/version':'14.1']

So either we get a quick fix or this needs a revert.

@@ -5,7 +5,7 @@
"metadata": {
"labels": {
"app.kubernetes.io/name": "postgres",
"app.kubernetes.io/version" : "10.6"
"app.kubernetes.io/version" : "14.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that this file shouldn't be changed and should be considered a static resource.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR in #22165

@gastaldi
Copy link
Contributor

Ah crap, you're right, I was looking at the app.kubernetes.io/version and didn't notice it was related to the postgresql image change.

gastaldi added a commit to gastaldi/quarkus that referenced this pull request Dec 13, 2021
@gastaldi gastaldi mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants