Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide meaningful error message when updating Quarkus in dev-mode #22151

Merged
merged 1 commit into from
Dec 13, 2021
+10 −4
Merged

Provide meaningful error message when updating Quarkus in dev-mode #22151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions core/deployment/src/main/java/io/quarkus/deployment/dev/IsolatedDevModeMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,12 +334,18 @@ public void close() {
fsWatchUtil.shutdown();
try {
stop();
if (RuntimeUpdatesProcessor.INSTANCE == null) {
throw new IllegalStateException(
"Hot deployment of the application is not supported when updating the Quarkus version. The application needs to be stopped and dev mode started up again");
}
} finally {
try {
try {
RuntimeUpdatesProcessor.INSTANCE.close();
} catch (IOException e) {
log.error("Failed to close compiler", e);
if (RuntimeUpdatesProcessor.INSTANCE != null) {
try {
RuntimeUpdatesProcessor.INSTANCE.close();
} catch (IOException e) {
log.error("Failed to close compiler", e);
}
}
for (HotReplacementSetup i : hotReplacementSetups) {
i.close();
Expand Down