Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent isDirectory checks in QuarkusCompiler #22135

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

Postremus
Copy link
Member

Use the URI scheme to determine if the path points to a classes directory, or an artifact jar.
This saves on isDirectory() calls, which are expensive on windows.

Saves about 40ms of dev mode startup time (on windows).

Related to #21552

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Postremus Postremus changed the title prevent isDirectory checks in QuarkusCompiler Prevent isDirectory checks in QuarkusCompiler Dec 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 39bdb27

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/opentelemetry/opentelemetry/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more

📦 extensions/opentelemetry/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.client line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

Use the URI scheme to determine if the path points to a classes directory, or an artifact jar.
This saves on isDirectory() calls, which are expensive on windows.
@Postremus Postremus force-pushed the faster-compiler-init branch from 39bdb27 to a7398b9 Compare December 13, 2021 15:42
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2021

Failing Jobs - Building a7398b9

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/opentelemetry/opentelemetry/deployment integration-tests/container-image/maven-invoker-way 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more

📦 extensions/opentelemetry/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.spanNameWithoutQueryString line 88 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/container-image/maven-invoker-way

Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-with-keycloak

org.acme.security.openid.connect.NativeBearerTokenAuthenticationIT.testAdminAccess - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
Caused by: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

org.acme.security.openid.connect.NativeBearerTokenAuthenticationIT.testAdminAccess - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
Caused by: java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

@Postremus
Copy link
Member Author

Postremus commented Dec 13, 2021

Test failures are becuase they are flaky. Does not look related.

2021-12-13T16:42:26.2033740Z [ERROR] io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.spanNameWithoutQueryString  Time elapsed: 30.308 s  <<< ERROR!

See #22156

@stuartwdouglas stuartwdouglas merged commit ee7e6c9 into quarkusio:main Dec 14, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 14, 2021
@stuartwdouglas
Copy link
Member

One of the flakey tests should be fixed here: #22174

Not sure what is going on with the others.

@Postremus Postremus deleted the faster-compiler-init branch December 14, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants