-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent isDirectory checks in QuarkusCompiler #22135
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 39bdb27
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/opentelemetry/opentelemetry/deployment
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more 📦 extensions/opentelemetry/opentelemetry/deployment✖
|
Use the URI scheme to determine if the path points to a classes directory, or an artifact jar. This saves on isDirectory() calls, which are expensive on windows.
39bdb27
to
a7398b9
Compare
Failing Jobs - Building a7398b9
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: extensions/opentelemetry/opentelemetry/deployment integration-tests/container-image/maven-invoker-way
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more 📦 extensions/opentelemetry/opentelemetry/deployment✖
📦 integration-tests/container-image/maven-invoker-way✖ 📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-with-keycloak✖
✖
|
Test failures are becuase they are flaky. Does not look related.
See #22156 |
One of the flakey tests should be fixed here: #22174 Not sure what is going on with the others. |
Use the URI scheme to determine if the path points to a classes directory, or an artifact jar.
This saves on isDirectory() calls, which are expensive on windows.
Saves about 40ms of dev mode startup time (on windows).
Related to #21552