Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ArcContainerImpl.requireRunning() check #22113

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Remove the ArcContainerImpl.requireRunning() check #22113

merged 1 commit into from
Dec 10, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 10, 2021

  • this check is more or less useless as the container is not guaranteed
    to be running after the method completes
  • ArcContainer.isRunning() can be still used to check the current status
    of the container

@mkouba
Remove the ArcContainerImpl.requireRunning() check
911aa73 
- this check is more or less useless as the container is not guaranteed
to be running after the method completes
- ArcContainer.isRunning() can be still used to check the current status
of the container
@mkouba mkouba requested a review from manovotn December 10, 2021 14:38
@mkouba mkouba added this to the 2.7 - main milestone Dec 10, 2021
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Dec 10, 2021
@Sanne Sanne merged commit c605c9a into quarkusio:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

@manovotn manovotn Awaiting requested review from manovotn

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@mkouba @Sanne