Fix native-image arguments generation for native-sources package type #22069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensures the NativeImageSecurityProvidersBuildItem is taken into account to add -H:AdditionalSecurityProviders as needed * Set the GraalVM version to `CURRENT`, since we can't know which version will eventually be used to build the native image. This enables us to at least make sure that the generated arguments will work properly with the currently supported GraalVM. * Don't `setContainerBuild` since we don't really know whether it will eventually be built with a builder-image or locally.
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
zakkak
changed the title
gsmet
approved these changes
Dec 9, 2021
|
Thanks! I did the backport to 2.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the NativeImageSecurityProvidersBuildItem is taken into
account to add -H:AdditionalSecurityProviders as needed
Set the GraalVM version to
CURRENT, since we can't know whichversion will eventually be used to build the native image.
This enables us to at least make sure that the generated arguments
will work properly with the currently supported GraalVM.
Don't
setContainerBuildsince we don't really know whether it willeventually be built with a builder-image or locally.
Backports Fix native-image arguments generation for native-sources package type #21809