Skip OIDC DevConsole setup if quarkus.oidc.auth-server-url can not be accessed at build time
#22042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
force-pushed
the
oidc_dev_console_exception
branch
from
d47b372 to
30f47d8
Compare
… accessed at build time
sberyozkin
force-pushed
the
oidc_dev_console_exception
branch
from
30f47d8 to
dcec760
Compare
phillip-kruger
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21951
Unfortunately this property is required to initialize Dev Console; I've been thinking, may be using
OidcConfigurationMetadatain the runtime supplier can be possible - I've tried it today and unfortunately the Arc context is not active at the point the supplier is called. So if theauth-server-urlis kept in Vault thenOidcDevConsolewill not be available - which is not a big problem.I may create another issue to check what can be done to access
OidcConfigurationMetadatain the supplier (it would make the code there cleaner as well).@phillip-kruger I've also reproduced the error you saw yesterday - it happens in the dev mode, when the discovery is disabled and either
authorization-pathortoken-pathare not configured - which is what OIDC Dev UI needs. So I've updated the supplier to do the optional checks only and added a test (which was failing before the updates :-) )