Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce order of arguments passed to native-image in container builds #21998

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Enforce order of arguments passed to native-image in container builds #21998

merged 1 commit into from
Dec 13, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Dec 7, 2021 •
edited
Loading

Forces quarkus.native.container-runtime-options to come after the base
arguments added by Quarkus to allow users to override the latter,
e.g. to override the --user option.

Closes: #17223

Creating as draft since I would like to perform some more tests first.

@zakkak
Enforce order of arguments passed to native-image in container builds
9dcaafa 
Forces `quarkus.native.container-runtime-options` to come after the base
arguments added by Quarkus to allow users to override the latter,
e.g. to override the --user option.

Closes: quarkusio#17223
@quarkus-bot quarkus-bot bot added the area/core label Dec 7, 2021
@zakkak zakkak removed the area/core label Dec 7, 2021
@zakkak zakkak mentioned this pull request Dec 7, 2021
Closed
@zakkak zakkak marked this pull request as ready for review December 9, 2021 11:50
@quarkus-bot quarkus-bot bot added the area/core label Dec 9, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2021

Failing Jobs - Building 9dcaafa

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/opentelemetry/opentelemetry/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more

📦 extensions/opentelemetry/opentelemetry/deployment

✖ io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.client line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@zakkak
Copy link
Contributor Author

zakkak commented Dec 9, 2021

The failure seems unrelated to the PR.

@gsmet gsmet merged commit 70c35b4 into quarkusio:main Dec 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 13, 2021
@zakkak zakkak deleted the fix-17223 branch December 13, 2021 09:33
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.0.Final Dec 13, 2021
@gsmet gsmet modified the milestones: 2.6.0.Final, 2.2.4.Final Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core area/native-image
Projects
None yet
Milestone
2.2.4.Final
Development

Successfully merging this pull request may close these issues.

Custom native container runtime options are overwritten
2 participants
@zakkak @gsmet