2.5.1 backports 3 #21829
Merged
2.5.1 backports 3 #21829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `ClassInfo.annotations` only returns the annotations at the current class level. This PR makes the parser method to also find the inherited annotations. Fix quarkusio#21759 (cherry picked from commit b44601a)
The regexp group "distro" was greedy and was capturing the java version as well. (cherry picked from commit 2cfbd4f)
(cherry picked from commit 2d3f799)
Bumps [gizmo](https://github.com/quarkusio/gizmo) from 1.0.9.Final to 1.0.10.Final. - [Release notes](https://github.com/quarkusio/gizmo/releases) - [Commits](quarkusio/gizmo@1.0.9.Final...1.0.10.Final) --- updated-dependencies: - dependency-name: io.quarkus.gizmo:gizmo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit 0797cb5)
…bled (cherry picked from commit 7f040cf)
- resolves quarkusio#21779 (cherry picked from commit 15337f9)
Signed-off-by: Phillip Kruger <[email protected]> (cherry picked from commit bc0b811)
…ted class RestClient Reactive generates a `...$$CDIWrapper` class for each RestClient interface, and creates an implementation of each RestClient method. This leaves non-RestClient methods (`default` methods) on the interface, which means that if they are annotated with an interceptor binding, the interceptor is not invoked. This is because interceptor bindings are not inherited from superinterfaces, only from superclasses (and while ArC has some support for intercepting `default` methods from superinterfaces, it doesn't extends that far). This PR doesn't attempt to support intercepting `default` methods in general, because that's a gray area. Instead, it fixes how RestClient Reactive generates the class for a RestClient interface (because RestClient interfaces are special in that they may define class-based beans if annotated `@RegisterRestClient`). In addition to RestClient methods, `default` methods from the RestClient interface are also copied to the generated class. (The "copy" delegates to the `default` method inherited from the superinterface, which had to be added to Gizmo, hence the Gizmo update.) That itself is enough for interceptors to start working. (cherry picked from commit 6b19e71)
quarkus-bot
bot
added
area/amazon-lambda
area/arc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge, I will merge it myself.