Update OIDC GitHub docs and update the test #21774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Nov 29, 2021
docs/src/main/asciidoc/security-openid-connect-web-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
improve_oidc_github_docs
branch
from
991e39d to
be8dfaf
Compare
gastaldi
approved these changes
Nov 29, 2021
docs/src/main/asciidoc/security-openid-connect-web-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
improve_oidc_github_docs
branch
from
0c23967 to
2dfd477
Compare
This comment has been minimized.
This comment has been minimized.
sberyozkin
force-pushed
the
improve_oidc_github_docs
branch
from
2dfd477 to
91b0008
Compare
|
@gastaldi Did a minor clarification to the docs (suggested to use both JsonWebToken and UserInfo as a possibly simpler alternative - would make sense if more than a name is required) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21743
This PR adds more content to the OIDC GitHub section and updates the test to verify the proposed doc changes.
CC @FroMage