Copy default methods of a RestClient Reactive interface to the generated class #21692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
|
Draft because we need quarkusio/gizmo#93 merged and released first. |
quarkus-bot
bot
added
area/dependencies
Ladicek
changed the title
…ted class RestClient Reactive generates a `...$$CDIWrapper` class for each RestClient interface, and creates an implementation of each RestClient method. This leaves non-RestClient methods (`default` methods) on the interface, which means that if they are annotated with an interceptor binding, the interceptor is not invoked. This is because interceptor bindings are not inherited from superinterfaces, only from superclasses (and while ArC has some support for intercepting `default` methods from superinterfaces, it doesn't extends that far). This PR doesn't attempt to support intercepting `default` methods in general, because that's a gray area. Instead, it fixes how RestClient Reactive generates the class for a RestClient interface (because RestClient interfaces are special in that they may define class-based beans if annotated `@RegisterRestClient`). In addition to RestClient methods, `default` methods from the RestClient interface are also copied to the generated class. (The "copy" delegates to the `default` method inherited from the superinterface, which had to be added to Gizmo, hence the Gizmo update.) That itself is enough for interceptors to start working.
Ladicek
force-pushed
the
restclient-reactive-copy-default-methods
branch
from
a0ab2e6 to
6b19e71
Compare
|
Rebased and marked ready for review, as Quarkus was updated to use Gizmo 1.0.10.Final. |
geoand
approved these changes
Nov 30, 2021
|
Do we want to backport this to |
|
Good point, I think we should. Added a label. |
|
CC @edeandrea |
michalszynkiewicz
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestClient Reactive generates a
...$$CDIWrapperclass for eachRestClient interface, and creates an implementation of each
RestClient method. This leaves non-RestClient methods (
defaultmethods) on the interface, which means that if they are annotated
with an interceptor binding, the interceptor is not invoked.
This is because interceptor bindings are not inherited from
superinterfaces, only from superclasses (and while ArC has some
support for intercepting
defaultmethods from superinterfaces,it doesn't extends that far).
This PR doesn't attempt to support intercepting
defaultmethodsin general, because that's a gray area. Instead, it fixes how
RestClient Reactive generates the class for a RestClient interface
(because RestClient interfaces are special in that they may define
class-based beans if annotated
@RegisterRestClient). In additionto RestClient methods,
defaultmethods from the RestClientinterface are also copied to the generated class. (The "copy"
delegates to the
defaultmethod inherited from the superinterface,which had to be added to Gizmo, hence the Gizmo update.) That itself
is enough for interceptors to start working.
Fixes #21674