Reuse already created FileSystems during collection of ApplicationArchive #21660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures seem kinda not related. Will do a rebase on main later to pick up latest fixes / let ci re run. |
Postremus
force-pushed
the
reduce-created-zipfilesystems
branch
from
26cda69 to
1bc93db
Compare
stuartwdouglas
approved these changes
Nov 24, 2021
stuartwdouglas
requested changes
Nov 24, 2021
core/deployment/src/main/java/io/quarkus/deployment/index/ApplicationArchiveBuildStep.java
Outdated
Show resolved
Hide resolved
Postremus
force-pushed
the
reduce-created-zipfilesystems
branch
from
1bc93db to
a08894b
Compare
Postremus
force-pushed
the
reduce-created-zipfilesystems
branch
from
a08894b to
316ced1
Compare
…hive the applicationarchive contains paths that are inside a zipfilesystem (of .jar files), needing the filesystem to be kept open during the whole build. During collection of the applicationarchives by marker files (e.g. META-INF/jandex.idx), a fs is opened for checking for a marker file, and the opened again to be used for the paths of the apparchive. Simply reusing the filesystems saves a few cycles. Since, at least on windows, opening new ZipFileSystems is relatively expensive.
Postremus
force-pushed
the
reduce-created-zipfilesystems
branch
from
6c62e86 to
d0594d4
Compare
|
@stuartwdouglas |
stuartwdouglas
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The applicationarchive contains paths that are inside a zipfilesystem (of .jar files), needing the filesystem to be kept open during the whole build.
During collection of the applicationarchives by marker files (e.g. META-INF/jandex.idx), a fs is opened for checking for a marker file, and the opened again to be used for the paths of the apparchive.
Also, try to reduce the amount of calls to isDIrectory, since this also showed up in my profiling.
On my (windows) machine, this change saves about 20ms of the dev mode startup time.
Relates to #21552, but not a complete fix.