Make quarkus-jdbc-mysql work properly in native mode for Java 17 #21637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanne
requested changes
Nov 23, 2021
There was a problem hiding this comment.
Nice one, thanks.
As far as I see, JMX registration is disabled by default but the user has the ability to opt-in; meaning that we'll silently disregard his wishes even when explicitly opting in.
Could you patch the methods to trow a meaninful exception rather then being empty?
There's also ReplicationConnectionGroupManager and LoadBalanceConnectionGroupManager to patch in a similar way - I guess it didn't trigger in our tests? Although one delegated to the other one you patched, but it sets hasRegisteredJmx = true which might be confusing.
|
Good points - done |
Sanne
added
area/persistence
|
YW! |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21366
I tested this with the
jpa-mysqlintegration test being run with Java 17 and GraalVM 17 (which we don't run in our CI)