Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed escaping of properties for azure-functions-http archetype #21635

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

mswiderski
Copy link
Contributor

fixes escaping of properties to not have them expanded by archetype information to avoid following in generated app

    <azure.functions.maven.plugin.version>1.9.1</azure.functions.maven.plugin.version>
    <functionAppName>quarkus-azure-functions-http-archetype-20211122143239183</functionAppName>
    <functionAppRegion>westus</functionAppRegion>
    <functionResourceGroup>java-functions-group</functionResourceGroup>
    <function>quarkus</function>
    <stagingDirectory>/data/home/gsmet/git/quarkus-release/work/quarkus/extensions/azure-functions-http/maven-archetype/target/azure-functions/${functionAppName}</stagingDirectory>
    <quarkus.package.type>uber-jar</quarkus.package.type>
  </properties>
  <dependencies>

and similar in the plugins

  <resources>
    <resource>
      <directory>/data/home/gsmet/git/quarkus-release/work/quarkus/extensions/azure-functions-http/maven-archetype/azure-config</directory>
      <includes>
        <include>host.json</include>
        <include>local.settings.json</include>
      </includes>
    </resource>
  </resources>
</configuration>

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 23, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@mswiderski mswiderski changed the title fixed escaping of properties for azure-functions-http archetype Fixed escaping of properties for azure-functions-http archetype Nov 23, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@gsmet gsmet merged commit 650b323 into quarkusio:main Nov 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 23, 2021
@mswiderski mswiderski deleted the azure-archetype-fix branch November 23, 2021 11:09
@gsmet gsmet modified the milestones: 2.6 - main, 2.5.1.Final Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants